Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

[WIP] Synchronize the changes between the configuration files and workspace devfile #1095

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] Synchronize the changes between the configuration files and workspace devfile #1095

wants to merge 2 commits into from

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Apr 30, 2021 •
edited
Loading

@codecov
Copy link

codecov bot commented Apr 30, 2021 •
edited
Loading

Codecov Report

Merging #1095 (58c71a5) into main (c299f59) will decrease coverage by 0.73%.
The diff coverage is 51.80%.

❗ Current head 58c71a5 differs from pull request most recent head 6c22e48. Consider uploading reports for the commit 6c22e48 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
- Coverage   32.78%   32.05%   -0.74%     
==========================================
  Files         290      279      -11     
  Lines        9885     9575     -310     
  Branches     1457     1446      -11     
==========================================
- Hits         3241     3069     -172     
+ Misses       6641     6504     -137     
+ Partials        3        2       -1
Impacted Files Coverage Δ
...heia-workspace/src/browser/che-workspace-module.ts 0.00% <0.00%> (ø)
...pace/src/browser/workspace-config-files-watcher.ts 58.10% <58.10%> (ø)
...eclipse-che-theia-plugin-ext/src/plugin/che-api.ts 26.53% <0.00%> (-0.84%) ⬇️
...erver/src/node/che-server-endpoint-service-impl.ts 82.92% <0.00%> (-0.41%) ⬇️
...server/src/node/che-server-devfile-service-impl.ts 87.85% <0.00%> (-0.17%) ⬇️
generator/src/yargs.ts 0.00% <0.00%> (ø)
plugins/ports-plugin/src/main.ts 0.00% <0.00%> (ø)
plugins/task-plugin/src/utils.ts 0.00% <0.00%> (ø)
generator/src/cdn/webpack.config.ts 0.00% <0.00%> (ø)
plugins/ssh-plugin/src/ssh-plugin.ts 0.00% <0.00%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f85127c...6c22e48. Read the comment docs.

@che-bot

This comment has been minimized.

Sign in to view
@che-bot

This comment has been minimized.

Sign in to view
@che-bot

This comment has been minimized.

Sign in to view
@che-bot

This comment has been minimized.

Sign in to view
@che-bot

This comment has been minimized.

Sign in to view
@che-bot

This comment has been minimized.

Sign in to view
@azatsarynnyy
Testing
6c22e48 
Signed-off-by: Artem Zatsarynnyi <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Sep 22, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1095
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1095

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@azatsarynnyy
Copy link
Member Author

After updating the workspace by providing a new devfile content to devfileService.updateDevfile I get:

alert:Getting workspace detail data failed. Failed to fetch the workspace wksp-tfnf-axot, reason: Could not retrieve mainUrl for the running workspace

in the Dashboard.

kubectl describe dw/wksp-tfnf-axot -n admin-che shows no Main URL: .

Continue investigating...

@azatsarynnyy azatsarynnyy mentioned this pull request Oct 29, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RomanNikitenko RomanNikitenko Awaiting requested review from RomanNikitenko RomanNikitenko will be requested when the pull request is marked ready for review RomanNikitenko is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azatsarynnyy @che-bot